[RFC] Randr 1.3 feature - get property

Jesse Barnes jbarnes at virtuousgeek.org
Mon Mar 10 11:42:02 PDT 2008

On Monday, March 10, 2008 11:37 am Matthias Hopf wrote:
> On Mar 10, 08 10:23:53 -0700, Jesse Barnes wrote:
> > > > One possible way would be to let xf86CrtcScreenInit() return the
> > > > version number instead of a Bool. That would even be backward
> > > > compatible.
> Actually, xf86CrtcConfigInit() would be the natural choice, but that
> returns void unfortunately.
> > > I'd be ok with that, do you want to hack up the change or should I? 
> > > The driver changes should be pretty trivial...
> Actually, no driver change is necessary at first, only if some driver
> wants to remain backward compatible. Heck, I don't even know whether we
> want to do that with radeonhd, but I want to be able to if I wish.
> Please check the attached patch, it should do the trick. I'll commit if
> you agree that this is fine. My buildsystem is currently not in a state
> to build master, but that'll hopefully change over night so I can build
> verify tomorrow. :-/
> > Actually, you should be able to use sizeof(crtc struct) as a check now
> > that we've changed it.  And going forward you can just check
> > crtc->version.
> I said run-time check. You're talking about a compile time check, for
> that the macro RANDR_13_INTERFACE is sufficient.

Oh right, yeah sizeof() is only good for compile time.

Patch looks fine to me, I guess it means we can get rid of the structure 
version fields too?


More information about the xorg mailing list