startx broken due to bashisms

Jeremy C. Reed reed at reedmedia.net
Fri Feb 24 19:09:54 PST 2006


On Sat, 26 Nov 2005, Donnie Berkholz wrote:

> | /usr/X11R6/bin/startx: arith: syntax error: "dummy+1"
> 
> | The dummy=$((dummy+1)); appears to be added in revision 1.3.
> 
> This work?

The attachment had:
-        dummy=$((dummy+1));
+        dummy=`expr $dummy + 1`

I can't remember if I tested this.

I do see that pkgsrc's startx uses:

diff -b -u -r1.7 startx.cpp
--- app/xinit/startx.cpp	15 Nov 2005 04:03:10 -0000	1.7
+++ app/xinit/startx.cpp	24 Feb 2006 22:14:35 -0000
@@ -208,7 +208,7 @@
 EOF
 	removelist="$displayname $removelist"
     else
-        dummy=$((dummy+1));
+        dummy=$(($dummy + 1));
         XAUTH -q -f $xserverauthfile << EOF
 add :$dummy . $authcookie
 EOF


May I commit either of the above?

 Jeremy C. Reed

 	  	 	 technical support & remote administration
	  	 	 http://www.pugetsoundtechnology.com/



More information about the xorg mailing list