startx broken due to bashisms

[Geller Sandor]

On Fri, 24 Feb 2006, Jeremy C. Reed wrote:

> The attachment had:
> -        dummy=$((dummy+1));
> +        dummy=`expr $dummy + 1`
>
> I can't remember if I tested this.
>
> I do see that pkgsrc's startx uses:
>
> diff -b -u -r1.7 startx.cpp
> --- app/xinit/startx.cpp	15 Nov 2005 04:03:10 -0000	1.7
> +++ app/xinit/startx.cpp	24 Feb 2006 22:14:35 -0000
> @@ -208,7 +208,7 @@
> EOF
> 	removelist="$displayname $removelist"
>     else
> -        dummy=$((dummy+1));
> +        dummy=$(($dummy + 1));
>         XAUTH -q -f $xserverauthfile << EOF
> add :$dummy . $authcookie
> EOF
>
>
> May I commit either of the above?

I reported this bug several months ago (see freedesktop.org bugzilla
bug #4449).

   Geller Sandor <wildy at petra.hos.u-szeged.hu>