[Xorg-driver-geode] [PATCH 0/3] Conditionally build the ZTV driver

[Gaetan Nadon]

On Wed, 2011-11-16 at 23:47 +0200, Martin-Éric Racine wrote:

> 2011/11/16 Gaetan Nadon <memsize at videotron.ca>:
> 
> > Any particular reasons why not? I know this is a bit of a shocker, but
> > having multiple targets in a makefile is error prone. The command to build
> > the ztv driver is all wrong. Leaving it in the same makefile will just make
> > it worse. When ever someone changes AM_CFLAGS, it applies to ztv as well and
> > no one would even think about it.
> 
> Mostly, because our driver is not so hugely complex that it would
> warrant having a separate directory and separate makefile/autoconf.ac,
> etc just for one C file.

I know, it's a bit overkill. But it is very different in nature.

> 
> One thing I would do, though, is to rename the C file (and resulting
> driver) to something more descriptive e.g. lx_v4l2_input.c to avoid
> the neverending questions about what the hell is that z4l thing
> supposed to do.

Yeah! I had a heck of a hard time finding anything. Actually ztv had
more hits as it was apparently renamed from z4l. 

> 
> > The first patch was just to move as I don't want to change many too things
> > at once. I have a few patches to follow-up and fix the makefile to be
> > correct for ztv. We can reassess after that and I can move it back if need
> > be.
> 
> Agreed. Let's focus on the code cleanup first and then decide whether
> we want the separate directory after.

Ok, I'll let you guys decide. I can build ztv on AMD64 while I cannot
build geode, so bonus for me :-)

> 
> Cheers!
> Martin-Éric


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20111116/33e9bd5f/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20111116/33e9bd5f/attachment.pgp>