<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2"> </HEAD> <BODY> On Wed, 2011-11-16 at 23:47 +0200, Martin-Éric Racine wrote: <BLOCKQUOTE TYPE=CITE> <PRE> 2011/11/16 Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>>: > Any particular reasons why not? I know this is a bit of a shocker, but > having multiple targets in a makefile is error prone. The command to build > the ztv driver is all wrong. Leaving it in the same makefile will just make > it worse. When ever someone changes AM_CFLAGS, it applies to ztv as well and > no one would even think about it. Mostly, because our driver is not so hugely complex that it would warrant having a separate directory and separate makefile/autoconf.ac, etc just for one C file. </PRE> </BLOCKQUOTE> I know, it's a bit overkill. But it is very different in nature. <BLOCKQUOTE TYPE=CITE> <PRE> One thing I would do, though, is to rename the C file (and resulting driver) to something more descriptive e.g. lx_v4l2_input.c to avoid the neverending questions about what the hell is that z4l thing supposed to do. </PRE> </BLOCKQUOTE> Yeah! I had a heck of a hard time finding anything. Actually ztv had more hits as it was apparently renamed from z4l. <BLOCKQUOTE TYPE=CITE> <PRE> > The first patch was just to move as I don't want to change many too things > at once. I have a few patches to follow-up and fix the makefile to be > correct for ztv. We can reassess after that and I can move it back if need > be. Agreed. Let's focus on the code cleanup first and then decide whether we want the separate directory after. </PRE> </BLOCKQUOTE> Ok, I'll let you guys decide. I can build ztv on AMD64 while I cannot build geode, so bonus for me :-) <BLOCKQUOTE TYPE=CITE> <PRE> Cheers! Martin-Éric </PRE> </BLOCKQUOTE> <BR> </BODY> </HTML>