[Xorg-driver-geode] [PATCH 0/3] Conditionally build the ZTV driver

[Martin-Éric Racine]

2011/11/16 Gaetan Nadon <memsize at videotron.ca>:

> Any particular reasons why not? I know this is a bit of a shocker, but
> having multiple targets in a makefile is error prone. The command to build
> the ztv driver is all wrong. Leaving it in the same makefile will just make
> it worse. When ever someone changes AM_CFLAGS, it applies to ztv as well and
> no one would even think about it.

Mostly, because our driver is not so hugely complex that it would
warrant having a separate directory and separate makefile/autoconf.ac,
etc just for one C file.

One thing I would do, though, is to rename the C file (and resulting
driver) to something more descriptive e.g. lx_v4l2_input.c to avoid
the neverending questions about what the hell is that z4l thing
supposed to do.

> The first patch was just to move as I don't want to change many too things
> at once. I have a few patches to follow-up and fix the makefile to be
> correct for ztv. We can reassess after that and I can move it back if need
> be.

Agreed. Let's focus on the code cleanup first and then decide whether
we want the separate directory after.

Cheers!
Martin-Éric