[Xorg-driver-geode] [PATCH 4/7] Put the one pixel drawing work to the server to handle

Otavio Salvador otavio at ossystems.com.br
Thu Jun 10 07:20:57 PDT 2010

Hello Chris,

On Thu, Jun 10, 2010 at 11:09 AM, Chris Ball <cjb at laptop.org> wrote:

> Hi,
>   > Dropping the empty line makes it easier to read (between the
>   > command the the if block).
> I was going to mention the same thing in my initial review, but then
> I noticed that the surrounding code in src/lx_exa.c is full of that
> extra-line style.  So, I think fitting in with the nearby context is
> more important in this case.

I'm unsure if I agree; I think that the coding style on this driver is a
mess and we ought to start fixing it when we change it.

Otavio Salvador                  O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20100610/2aa3d68d/attachment.htm>

More information about the Xorg-driver-geode mailing list