[Xorg-driver-geode] [PATCH 4/7] Put the one pixel drawing work to the server to handle
dilinger at queued.net
Thu Jun 10 12:28:12 PDT 2010
On Thu, 10 Jun 2010 11:20:57 -0300
Otavio Salvador <otavio at ossystems.com.br> wrote:
> Hello Chris,
> On Thu, Jun 10, 2010 at 11:09 AM, Chris Ball
> <cjb at laptop.org> wrote:
> > Hi,
> > > Dropping the empty line makes it easier to read (between the
> > > command the the if block).
> > I was going to mention the same thing in my initial review, but then
> > I noticed that the surrounding code in src/lx_exa.c is full of that
> > extra-line style. So, I think fitting in with the nearby context is
> > more important in this case.
> I'm unsure if I agree; I think that the coding style on this driver
> is a mess and we ought to start fixing it when we change it.
Rather than changing a single instance of it then, I'd recommend a
separate patch to remove all extraneous blank lines after comments
(that sits atop of Frank's patch).
More information about the Xorg-driver-geode