Hello Chris,<br><br><div class="gmail_quote">On Thu, Jun 10, 2010 at 11:09 AM, Chris Ball <span dir="ltr"><<a href="mailto:cjb@laptop.org">cjb@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<div class="im"><br>
> Dropping the empty line makes it easier to read (between the<br>
> command the the if block).<br>
<br>
</div>I was going to mention the same thing in my initial review, but then<br>
I noticed that the surrounding code in src/lx_exa.c is full of that<br>
extra-line style. So, I think fitting in with the nearby context is<br>
more important in this case.<br></blockquote></div><br>I'm unsure if I agree; I think that the coding style on this driver is a mess and we ought to start fixing it when we change it.<br clear="all"><br>-- <br>Otavio Salvador O.S. Systems<br>
E-mail: <a href="mailto:otavio@ossystems.com.br">otavio@ossystems.com.br</a> <a href="http://www.ossystems.com.br">http://www.ossystems.com.br</a><br>Mobile: +55 53 9981-7854 <a href="http://projetos.ossystems.com.br">http://projetos.ossystems.com.br</a><br>
<br>