[PATCH:libX11] Xcms file parsing should not require the impossible to succeed

Dan Nicholson dbn.lists at gmail.com
Thu Oct 24 15:23:57 CEST 2013

On Oct 23, 2013 10:49 PM, "Alan Coopersmith" <alan.coopersmith at oracle.com>
> On 10/23/13 01:45 PM, Alan Coopersmith wrote:
> > This has gone unnoticed since 1991, until gcc -Wlogicalop came to our
>> rescue, and https://bugs.freedesktop.org/show_bug.cgi?id=70803 was filed.
> And I probably should have mentioned it's gone unnoticed because the
effect is
> truly minor - it's only hit on lines in Xcms.txt that start with
> which no color entry line shipped in any X.Org release ever did.
> You can see this with our current Xcms.txt if you edit it and put a space
> the start of the "cms red" color line - after doing so, without this fix,
> 'xlogo -bg "cms red"' will fail, with this fix (or without the added
> you'll get a red background in the logo display.

I'm guessing that's exactly why no entries ever started with whitespace -
they wouldn't actually work. :)

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131024/4e77fbf6/attachment-0001.html>

More information about the xorg-devel mailing list