[PATCH:libX11] Xcms file parsing should not require the impossible to succeed

Alan Coopersmith alan.coopersmith at oracle.com
Thu Oct 24 07:49:27 CEST 2013

On 10/23/13 01:45 PM, Alan Coopersmith wrote:
 > This has gone unnoticed since 1991, until gcc -Wlogicalop came to our
> rescue, and https://bugs.freedesktop.org/show_bug.cgi?id=70803 was filed.

And I probably should have mentioned it's gone unnoticed because the effect is
truly minor - it's only hit on lines in Xcms.txt that start with whitespace,
which no color entry line shipped in any X.Org release ever did.

You can see this with our current Xcms.txt if you edit it and put a space at
the start of the "cms red" color line - after doing so, without this fix,
'xlogo -bg "cms red"' will fail, with this fix (or without the added space),
you'll get a red background in the logo display.

	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc

More information about the xorg-devel mailing list