On Oct 23, 2013 10:49 PM, "Alan Coopersmith" <<a href="mailto:alan.coopersmith@oracle.com">alan.coopersmith@oracle.com</a>> wrote: > > On 10/23/13 01:45 PM, Alan Coopersmith wrote: > > This has gone unnoticed since 1991, until gcc -Wlogicalop came to our >> >> rescue, and <a href="https://bugs.freedesktop.org/show_bug.cgi?id=70803">https://bugs.freedesktop.org/show_bug.cgi?id=70803</a> was filed. > > > And I probably should have mentioned it's gone unnoticed because the effect is > truly minor - it's only hit on lines in Xcms.txt that start with whitespace, > which no color entry line shipped in any X.Org release ever did. > > You can see this with our current Xcms.txt if you edit it and put a space at > the start of the "cms red" color line - after doing so, without this fix, > 'xlogo -bg "cms red"' will fail, with this fix (or without the added space), > you'll get a red background in the logo display. I'm guessing that's exactly why no entries ever started with whitespace - they wouldn't actually work. :) Reviewed-by: Dan Nicholson <<a href="mailto:dbn.lists@gmail.com">dbn.lists@gmail.com</a>>