[PATCH] test/xi2: fix protocol-xiqueryversion test

Peter Hutterer peter.hutterer at who-t.net
Wed Jul 31 22:28:53 PDT 2013


On Tue, Jul 30, 2013 at 12:51:46PM -0500, Keith Packard wrote:
> Maarten Lankhorst <maarten.lankhorst at canonical.com> writes:
> 
> > The old code was broken and allowed setting client version >= XIVersion,
> > this was fixed in the previous patch, but updating the value for XIVersion
> > broke the tests, so fix the tests too.
> 
> Yeah, having the expected/checked versions explicitly listed in the
> tests is way better than what I did in my patch.
> 
> However, I think what we probably want is to have a helper function that
> takes a trio of server/client/expected versions so we can see those in
> the same spot in the test and manually verify them. As written, it's
> really hard to make sure the numbers are set correctly in the test_data
> structure.

indeed, but that'll be a follow-up patch if anyone finds the time for it.
meanwhile, pushed to make things built properly again.

   e1ab8f2..b6e5c46  master -> master


Cheers,
   Peter


More information about the xorg-devel mailing list