[PATCH] Xi: Clamp XIClient maximal version to XIVersion

[Keith Packard]

Maarten Lankhorst <maarten.lankhorst at canonical.com> writes:

> Do not allow setting client version to an arbitrary value >= XIVersion.
> Fixes a test error with test/xi2/protocol-xiqueryversion.c, introduced by
> commit 4360514d1c "Xi: Allow clients to ask for 2.3 and then 2.2
> without failing"

Heh. My slow internet access caused me to write exactly the same patch
(as near as I can tell).

> -                client->errorValue = stuff->major_version;
> +                client->errorValue = major;


This should remain stuff->major_version -- we always send back the
client supplied data in the BadValue request (not that it really
matters, as no-one is likely to care, but...)

Other than that,

Reviewed-by: Keith Packard <keithp at keithp.com>


-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130730/df0fb408/attachment.pgp>