[PATCH] test/xi2: fix protocol-xiqueryversion test

Keith Packard keithp at keithp.com
Tue Jul 30 10:51:46 PDT 2013


Maarten Lankhorst <maarten.lankhorst at canonical.com> writes:

> The old code was broken and allowed setting client version >= XIVersion,
> this was fixed in the previous patch, but updating the value for XIVersion
> broke the tests, so fix the tests too.

Yeah, having the expected/checked versions explicitly listed in the
tests is way better than what I did in my patch.

However, I think what we probably want is to have a helper function that
takes a trio of server/client/expected versions so we can see those in
the same spot in the test and manually verify them. As written, it's
really hard to make sure the numbers are set correctly in the test_data
structure.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130730/9da56b07/attachment.pgp>


More information about the xorg-devel mailing list