[PULL: xserver master] Reworking initializion of data sent to clients

Alan Coopersmith alan.coopersmith at oracle.com
Mon Jul 9 17:29:24 PDT 2012


I think I got all the reviewed-by tags applied to the patches that got them,
but a big chunk in the middle didn't get anyone reviewing, even after the
rewrite to simplify.    So far the server seems to be working with them, so
if I broke something, it was somewhere less obvious.

I haven't gone through to check the just added randr 1.4 bits yet - hopefully
we can get that in as a small cleanup post merge window.

The following changes since commit 329db3292223cccd4887062956622285c45a1523:

  dri2/prime: allocate prime id at screen allocation time (2012-07-07 10:39:10
+0100)

are available in the git repository at:

  git+ssh://people.freedesktop.org/~alanc/xserver.git c99-init

for you to fetch changes up to c5b85ce68a69180fecd11d6abb3acbeaed1217a8:

  Replace padlength tables with inline functions from misc.h (2012-07-09
17:22:57 -0700)

----------------------------------------------------------------
Alan Coopersmith (28):
      Remove unneccesary casts from WriteToClient calls
      Fix more poorly indented/wrapped comments & code
      Rework reply initialization in ProcGetProperty & NullPropertyReply
      Core events: invert check for permission to copy key states
      ProcQueryKeymap: rework logic around permission to copy key states
      Use temporary variables instead of parts of reply structures
      ProcRRGetScreenInfo: swap configTimestamp as well
      ProcRRListOutputProperties: skip atom walk if the list is empty
      xf86dga2.c & xf86vmode.c: Move REQUEST_SIZE_MATCH checks before using stuff
      Use calloc to zero fill buffers being allocated for replies & events
      Use C99 designated initializers in SendErrorToClient
      Use C99 designated initializers in dix Replies
      Use C99 designated initializers in Xext Replies
      Use C99 designated initializers in Xinput Replies
      Use C99 designated initializers in various extension Replies
      Use C99 designated initializers in glx Replies
      Use C99 designated initializers in xkb Replies
      Use C99 designated initializers in randr Replies
      Use C99 designated initializers in dmx Replies
      Use C99 designated initializers in Xephyr Replies
      Use C99 designated initializers in xf86 extension Replies
      Use C99 designated initializers in dix Events
      Use C99 designated initializers in extension Events
      Use C99 designated initializers in dix registry
      Set padding bytes to 0 in WriteToClient
      Initialize padding bits to 0 in ErrorConnMax()
      ephyrGLXQueryServerString: Stop making an unused copy of server_string
      Replace padlength tables with inline functions from misc.h

Jaroslav Šmíd (1):
      Bug 51375: Xorg doesn't set status for RRGetOutputInfo

 Xext/bigreq.c                         |   13 +-
 Xext/dpms.c                           |   63 +++---
 Xext/geext.c                          |   18 +-
 Xext/panoramiX.c                      |   92 +++++----
 Xext/panoramiXprocs.c                 |   47 +++--
 Xext/saver.c                          |   51 ++---
 Xext/security.c                       |   40 ++--
 Xext/shape.c                          |   81 ++++----
 Xext/shm.c                            |   75 ++++---
 Xext/sync.c                           |  142 +++++++------
 Xext/xcmisc.c                         |   42 ++--
 Xext/xf86bigfont.c                    |   37 ++--
 Xext/xres.c                           |   87 ++++----
 Xext/xselinux_ext.c                   |   42 ++--
 Xext/xtest.c                          |   28 +--
 Xext/xvdisp.c                         |  186 +++++++++--------
 Xext/xvmain.c                         |   26 +--
 Xext/xvmc.c                           |  124 ++++++-----
 Xi/chgdctl.c                          |   25 ++-
 Xi/exevents.c                         |   13 +-
 Xi/extinit.c                          |    5 +-
 Xi/getbmap.c                          |   16 +-
 Xi/getdctl.c                          |   12 +-
 Xi/getfctl.c                          |   14 +-
 Xi/getfocus.c                         |   12 +-
 Xi/getkmap.c                          |   14 +-
 Xi/getmmap.c                          |   16 +-
 Xi/getprop.c                          |   14 +-
 Xi/getselev.c                         |   16 +-
 Xi/getvers.c                          |   19 +-
 Xi/grabdev.c                          |   12 +-
 Xi/grabdevb.c                         |   15 +-
 Xi/grabdevk.c                         |   15 +-
 Xi/gtmotion.c                         |   20 +-
 Xi/listdev.c                          |   13 +-
 Xi/opendev.c                          |   17 +-
 Xi/queryst.c                          |   16 +-
 Xi/setbmap.c                          |   14 +-
 Xi/setdval.c                          |   14 +-
 Xi/setmmap.c                          |   12 +-
 Xi/setmode.c                          |   12 +-
 Xi/xigetclientpointer.c               |   16 +-
 Xi/xigrabdev.c                        |   14 +-
 Xi/xipassivegrab.c                    |   18 +-
 Xi/xiproperty.c                       |  109 +++++-----
 Xi/xiquerydevice.c                    |   15 +-
 Xi/xiquerypointer.c                   |   21 +-
 Xi/xiqueryversion.c                   |   17 +-
 Xi/xiselectev.c                       |   14 +-
 Xi/xisetdevfocus.c                    |   12 +-
 composite/compext.c                   |   37 ++--
 composite/compwindow.c                |    6 +-
 config/udev.c                         |    6 +-
 damageext/damageext.c                 |   32 +--
 dbe/dbe.c                             |   46 ++---
 dix/colormap.c                        |   40 ++--
 dix/devices.c                         |  154 +++++++-------
 dix/dispatch.c                        |  259 ++++++++++++-----------
 dix/dixfonts.c                        |   26 +--
 dix/enterleave.c                      |   23 ++-
 dix/events.c                          |  175 +++++++++-------
 dix/extension.c                       |   22 +-
 dix/grabs.c                           |    5 +-
 dix/inpututils.c                      |   13 +-
 dix/property.c                        |   76 ++++---
 dix/registry.c                        |    4 +-
 dix/selection.c                       |   19 +-
 dix/swaprep.c                         |   88 ++++----
 dix/swapreq.c                         |    2 +-
 dix/window.c                          |  190 +++++++++--------
 glx/glxcmds.c                         |  137 ++++++------
 glx/glxcmdsswap.c                     |   18 +-
 glx/glxdri2.c                         |    5 +-
 glx/indirect_util.c                   |    8 +-
 glx/single2.c                         |   20 +-
 glx/single2swap.c                     |   18 +-
 glx/unpack.h                          |   12 +-
 hw/dmx/dmx.c                          |  257 +++++++++++++----------
 hw/dmx/glxProxy/glxcmds.c             |  149 +++++++-------
 hw/dmx/glxProxy/glxcmdsswap.c         |   43 ++--
 hw/dmx/glxProxy/glxsingle.c           |   56 ++---
 hw/dmx/glxProxy/glxvendor.c           |   12 +-
 hw/dmx/glxProxy/unpack.h              |   12 +-
 hw/kdrive/ephyr/ephyrdriext.c         |  146 ++++++-------
 hw/kdrive/ephyr/ephyrglxext.c         |   95 +++++----
 hw/kdrive/ephyr/ephyrproxyext.c       |    2 +-
 hw/xfree86/common/xf86DGA.c           |  120 +++++------
 hw/xfree86/dixmods/extmod/xf86dga2.c  |  256 ++++++++++++-----------
 hw/xfree86/dixmods/extmod/xf86vmode.c |  298 ++++++++++++++-------------
 hw/xfree86/dri/xf86dri.c              |  145 ++++++-------
 hw/xfree86/dri2/dri2ext.c             |  127 ++++++------
 hw/xquartz/applewm.c                  |    6 +-
 hw/xquartz/pseudoramiX.c              |   12 +-
 hw/xquartz/xpr/appledri.c             |    8 +-
 hw/xwin/winwindowswm.c                |    4 +-
 include/dix.h                         |    4 +-
 include/misc.h                        |   14 ++
 mi/miexpose.c                         |   13 +-
 os/connection.c                       |    2 +-
 os/io.c                               |   12 +-
 randr/rrcrtc.c                        |  133 ++++++------
 randr/rrdispatch.c                    |   11 +-
 randr/rrmode.c                        |   15 +-
 randr/rroutput.c                      |   81 ++++----
 randr/rrproperty.c                    |   93 +++++----
 randr/rrscreen.c                      |  198 +++++++++---------
 randr/rrxinerama.c                    |   93 +++++----
 record/record.c                       |   49 +++--
 render/render.c                       |   22 +-
 test/input.c                          |   34 ++-
 xfixes/cursor.c                       |   41 ++--
 xfixes/region.c                       |    5 +-
 xfixes/select.c                       |   23 +--
 xfixes/xfixes.c                       |   12 +-
 xkb/xkb.c                             |  366 +++++++++++++++++----------------
 xkb/xkbEvents.c                       |   57 ++---
 116 files changed, 3338 insertions(+), 2895 deletions(-)

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list