[PULL: xserver master] Reworking initializion of data sent to clients
Keith Packard
keithp at keithp.com
Mon Jul 9 18:39:44 PDT 2012
Alan Coopersmith <alan.coopersmith at oracle.com> writes:
> Remove unneccesary casts from WriteToClient calls
> Fix more poorly indented/wrapped comments & code
> Rework reply initialization in ProcGetProperty & NullPropertyReply
Reviewed-by: Keith Packard <keithp at keithp.com>
> Core events: invert check for permission to copy key states
> ProcQueryKeymap: rework logic around permission to copy key states
Yeah, these seem pessimal, but obviously directed at making the patch to
use C99 initailizers clearer.
Reviewed-by: Keith Packard <keithp at keithp.com>
> Use temporary variables instead of parts of reply structures
> ProcRRGetScreenInfo: swap configTimestamp as well
> ProcRRListOutputProperties: skip atom walk if the list is empty
> xf86dga2.c & xf86vmode.c: Move REQUEST_SIZE_MATCH checks before using stuff
Reviewed-by: Keith Packard <keithp at keithp.com>
> Use calloc to zero fill buffers being allocated for replies & events
You aren't very consistent in using calloc -- sometimes (1, size),
sometimes (size, 1). Just sayin'
Reviewed-by: Keith Packard <keithp at keithp.com>
> Use C99 designated initializers in SendErrorToClient
> Use C99 designated initializers in dix Replies
> Use C99 designated initializers in Xext Replies
> Use C99 designated initializers in Xinput Replies
> Use C99 designated initializers in various extension Replies
> Use C99 designated initializers in glx Replies
> Use C99 designated initializers in xkb Replies
> Use C99 designated initializers in randr Replies
> Use C99 designated initializers in dmx Replies
> Use C99 designated initializers in Xephyr Replies
> Use C99 designated initializers in xf86 extension Replies
Reviewed-by: Keith Packard <keithp at keithp.com>
> Use C99 designated initializers in dix Events
Can't set .u.u.type in the initializer? Bummer.
Reviewed-by: Keith Packard <keithp at keithp.com>
> Use C99 designated initializers in extension Events
> Set padding bytes to 0 in WriteToClient
> Use C99 designated initializers in dix registry
> Initialize padding bits to 0 in ErrorConnMax()
> ephyrGLXQueryServerString: Stop making an unused copy of server_string
> Replace padlength tables with inline functions from misc.h
Reviewed-by: Keith Packard <keithp at keithp.com>
(three copies of the same array? Awesome!)
>
> Jaroslav Å mÃd (1):
> Bug 51375: Xorg doesn't set status for RRGetOutputInfo
Reviewed-by: Keith Packard <keithp at keithp.com>
--
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120709/e1050bf7/attachment.pgp>
More information about the xorg-devel
mailing list