[PATCH] modes: Replace xf86DefaultModes with DMTModes

Adam Jackson ajax at redhat.com
Tue Mar 8 13:21:02 PST 2011

On Tue, 2011-03-08 at 21:32 +0100, Mark Kettenis wrote:
> > Date: Tue, 8 Mar 2011 21:27:47 +0100 (CET)
> > From: Mark Kettenis <mark.kettenis at xs4all.nl>
> > 
> > > From: Adam Jackson <ajax at redhat.com>
> > > Date: Tue,  8 Mar 2011 14:56:33 -0500
> > > 
> > > DMTModes is what xf86DefaultModes was always meant to be.
> > 
> > I'd say xf86DefaultModes is a better variable name than DMTModes for
> > an exported symbol though.

If it makes you feel better, we can probably stop exporting it.  None of
the open drivers are using either symbol.  I think fglrx does, but the
thing about MIT-licensed code is...

> Hmm, looking at this a bit more, is it really ok to include the
> "reduced blanking" modes in xf86DefaultModes?

Yes.  We filter the default mode pool based on the monitor's
capabilities.  For non-randrful drivers, see xf86CheckModeForMonitor;
for randrful drivers see xf86ValidateModesReducedBlanking.  (Yes, these
paths should be made less redundant.)

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110308/0d9bbddd/attachment-0001.pgp>

More information about the xorg-devel mailing list