[PATCH] Unset XDG_SESSION_COOKIE as well.

Gaetan Nadon memsize at videotron.ca
Thu Aug 11 17:47:03 PDT 2011


On Thu, 2011-08-11 at 10:18 -0700, Alan Coopersmith wrote:

> On 08/11/11 09:48, Matěj Cepl wrote:
> > From: Adam Jackson <ajax at nwnk.net>
> > 
> > https://bugzilla.redhat.com/489999
> > Avoid collision with the ConsoleKit which doesn't start its session when
> > XDG_SESSION_COOKIE is set.
> > 
> > Signed-off-by: Matěj Cepl <mcepl at redhat.com>
> > ---
> >  startx.cpp |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/startx.cpp b/startx.cpp
> > index 9f6561d..f2aa630 100644
> > --- a/startx.cpp
> > +++ b/startx.cpp
> > @@ -11,6 +11,7 @@ XCOMM
> >  XCOMM Site administrators are STRONGLY urged to write nicer versions.
> >  XCOMM
> >  
> > +unset XDG_SESSION_COOKIE
> >  unset DBUS_SESSION_BUS_ADDRESS
> >  unset SESSION_MANAGER
> >  
> 
> Seems reasonable to me, so:
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> 
> But please include a hint to which module a patch goes with when sending
> patches for non-Xserver modules.   We assume unadorned "[PATCH]" is
> Xserver since it's the bulk of traffic, so prefer something like
> "[PATCH xinit]" for the rest - including it in the brackets allows
> it to show up in the e-mail, but not go into the git logs where it
> will already be obvious which module it's for.  You can automate this
> with git - for instance, my app/xinit/.git/config contains:
> 
> [format]
>         subjectprefix = PATCH:xinit


Matěj,

You can use "git config format.subjectprefix "PATCH $(mod_name)" if you
want to script the whole tree.

All this and other info are in a wiki:
http://www.x.org/wiki/Development/Documentation/SubmittingPatches


> 
> -- 
> 	-Alan Coopersmith-        alan.coopersmith at oracle.com
> 	 Oracle Solaris Platform Engineering: X Window System
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110811/8c0986e7/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110811/8c0986e7/attachment.pgp>


More information about the xorg-devel mailing list