<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2"> </HEAD> <BODY> On Thu, 2011-08-11 at 10:18 -0700, Alan Coopersmith wrote: <BLOCKQUOTE TYPE=CITE> <PRE> On 08/11/11 09:48, Matěj Cepl wrote: > From: Adam Jackson <<A HREF="mailto:ajax@nwnk.net">ajax@nwnk.net</A>> > > <A HREF="https://bugzilla.redhat.com/489999">https://bugzilla.redhat.com/489999</A> > Avoid collision with the ConsoleKit which doesn't start its session when > XDG_SESSION_COOKIE is set. > > Signed-off-by: Matěj Cepl <<A HREF="mailto:mcepl@redhat.com">mcepl@redhat.com</A>> > --- > startx.cpp | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/startx.cpp b/startx.cpp > index 9f6561d..f2aa630 100644 > --- a/startx.cpp > +++ b/startx.cpp > @@ -11,6 +11,7 @@ XCOMM > XCOMM Site administrators are STRONGLY urged to write nicer versions. > XCOMM > > +unset XDG_SESSION_COOKIE > unset DBUS_SESSION_BUS_ADDRESS > unset SESSION_MANAGER > Seems reasonable to me, so: Reviewed-by: Alan Coopersmith <<A HREF="mailto:alan.coopersmith@oracle.com">alan.coopersmith@oracle.com</A>> But please include a hint to which module a patch goes with when sending patches for non-Xserver modules. We assume unadorned "[PATCH]" is Xserver since it's the bulk of traffic, so prefer something like "[PATCH xinit]" for the rest - including it in the brackets allows it to show up in the e-mail, but not go into the git logs where it will already be obvious which module it's for. You can automate this with git - for instance, my app/xinit/.git/config contains: [format]         subjectprefix = PATCH:xinit </PRE> </BLOCKQUOTE> Matěj, You can use "git config format.subjectprefix "PATCH $(mod_name)" if you want to script the whole tree. All this and other info are in a wiki: <A HREF="http://www.x.org/wiki/Development/Documentation/SubmittingPatches">http://www.x.org/wiki/Development/Documentation/SubmittingPatches</A> <BLOCKQUOTE TYPE=CITE> <PRE> -- -Alan Coopersmith- <A HREF="mailto:alan.coopersmith@oracle.com">alan.coopersmith@oracle.com</A> Oracle Solaris Platform Engineering: X Window System _______________________________________________ <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>: X.Org development Archives: <A HREF="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</A> Info: <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>