[PATCH] Unset XDG_SESSION_COOKIE as well.
Alan Coopersmith
alan.coopersmith at oracle.com
Thu Aug 11 10:18:49 PDT 2011
On 08/11/11 09:48, Matěj Cepl wrote:
> From: Adam Jackson <ajax at nwnk.net>
>
> https://bugzilla.redhat.com/489999
> Avoid collision with the ConsoleKit which doesn't start its session when
> XDG_SESSION_COOKIE is set.
>
> Signed-off-by: Matěj Cepl <mcepl at redhat.com>
> ---
> startx.cpp | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/startx.cpp b/startx.cpp
> index 9f6561d..f2aa630 100644
> --- a/startx.cpp
> +++ b/startx.cpp
> @@ -11,6 +11,7 @@ XCOMM
> XCOMM Site administrators are STRONGLY urged to write nicer versions.
> XCOMM
>
> +unset XDG_SESSION_COOKIE
> unset DBUS_SESSION_BUS_ADDRESS
> unset SESSION_MANAGER
>
Seems reasonable to me, so:
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
But please include a hint to which module a patch goes with when sending
patches for non-Xserver modules. We assume unadorned "[PATCH]" is
Xserver since it's the bulk of traffic, so prefer something like
"[PATCH xinit]" for the rest - including it in the brackets allows
it to show up in the e-mail, but not go into the git logs where it
will already be obvious which module it's for. You can automate this
with git - for instance, my app/xinit/.git/config contains:
[format]
subjectprefix = PATCH:xinit
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list