[PATCH macros 2/3] docs: Take optional argument to control defaults

[Gaetan Nadon]

On Sat, 2010-10-09 at 17:41 -0700, Dan Nicholson wrote:

> The typical default of enabling documentation if the correct tool is
> found is usually the right thing to do. However, some packages such as
> Xlib have huge amounts of documentation that really only need to be
> built once to put into the tarball. Allow packages to specify the
> default by passing an argument to the macro.
> 
> Signed-off-by: Dan Nicholson <dbn.lists at gmail.com>



      * Can you change the commit text to reflect the fact that
        currently the docs are not included in the tarball?
      * An alternative is to overload the single parameter of the
        XORG_WITH_<TOOL> macros such that it's value are either "no" or
        "x.y.z" (minimum version). Usually not a nice thing to do, but
        in this case it helps consistency. They will all have just one
        parm.


With the changed commit text and if you think the alternative is not
desirable:
Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101012/2e2920c9/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101012/2e2920c9/attachment.pgp>