<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Sat, 2010-10-09 at 17:41 -0700, Dan Nicholson wrote: <BLOCKQUOTE TYPE=CITE> <TT>The typical default of enabling documentation if the correct tool is</TT> <TT>found is usually the right thing to do. However, some packages such as</TT> <TT>Xlib have huge amounts of documentation that really only need to be</TT> <TT>built once to put into the tarball. Allow packages to specify the</TT> <TT>default by passing an argument to the macro.</TT> <TT>Signed-off-by: Dan Nicholson <<A HREF="mailto:dbn.lists@gmail.com">dbn.lists@gmail.com</A>></TT> </BLOCKQUOTE> <UL> <LI>Can you change the commit text to reflect the fact that currently the docs are not included in the tarball? <LI>An alternative is to overload the single parameter of the XORG_WITH_<TOOL> macros such that it's value are either "no" or "x.y.z" (minimum version). Usually not a nice thing to do, but in this case it helps consistency. They will all have just one parm. </UL> With the changed commit text and if you think the alternative is not desirable: Reviewed-by: <TT>Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>></TT> </BODY> </HTML>