[PATCH macros 2/3] docs: Take optional argument to control defaults

Alan Coopersmith alan.coopersmith at oracle.com
Tue Oct 12 14:45:50 PDT 2010


Gaetan Nadon wrote:
>     * An alternative is to overload the single parameter of the
>       XORG_WITH_<TOOL> macros such that it's value are either "no" or
>       "x.y.z" (minimum version). Usually not a nice thing to do, but in
>       this case it helps consistency. They will all have just one parm. 

I don't like it, since it doesn't allow for setting a default of
"no" and requiring a minimum version if you enable it, and argument
overloading like that just seems confusing to people trying to
figure out what the scripts do.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list