[PATCH 1/4] Move region implementation from mi to dix.

[Keith Packard]

On 22 May 2010 02:57:34 +0200, Soeren Sandmann <sandmann at daimi.au.dk> wrote:

> Would it be useful to split this commit into two: one that just
> renames the file and one that is the result of running the script?

Yeah, that might make it easier to review.

> That way it becomes easier to see what precisely the script actually
> did, though it does mean there is an intermediate step where the
> region functions have the wrong name.

No, they'll have the right name, just be in the wrong file. The server
should build just fine. Unlike the other split-up patch, I can leave
this one in the final patch list and bisect will still work.

> Also, if we are renaming things anyway, maybe some functions should
> get moved into the Region name space. For example PointInRegion()
> could become RegionContainsPoint().

I'd rather leave the names as they are; they've been in use for a long
time...

> Other than those things, it looks good to me.

I've split up the patch which removes the 'mi' prefix from the region
function names and the file rename into two patches.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100522/fb644169/attachment.pgp>