[PATCH 1/4] Move region implementation from mi to dix.

Soeren Sandmann sandmann at daimi.au.dk
Fri May 21 17:57:34 PDT 2010


Keith Packard <keithp at keithp.com> writes:

> There isn't any reason to have this in mi. Everything except the file
> rename was done with the included script 'fix-miregion'.

Would it be useful to split this commit into two: one that just
renames the file and one that is the result of running the script?

That way it becomes easier to see what precisely the script actually
did, though it does mean there is an intermediate step where the
region functions have the wrong name.

Also, if we are renaming things anyway, maybe some functions should
get moved into the Region name space. For example PointInRegion()
could become RegionContainsPoint().

Other than those things, it looks good to me.


Søren


More information about the xorg-devel mailing list