[PATCH 1/4] Move region implementation from mi to dix.

Jamey Sharp jamey at minilop.net
Sat May 22 11:34:20 PDT 2010


On Sat, May 22, 2010 at 12:20 AM, Keith Packard <keithp at keithp.com> wrote:
> I've split up the patch which removes the 'mi' prefix from the region
> function names and the file rename into two patches.

If you want the s/mi// rename to be purely mechanical, I think you
need another commit first that moves the three declarations from
mi/mi.h and miClipSpans from mi/mispans.h into regionstr.h. As it
stands now, with the old prototypes being simply deleted, that commit
introduces warnings. Looks like you fixed it up two commits later, in
"Hand-rolled changes to cleanup region macro renaming".

Also, "Change region implementation from macros to inline functions"
undoes a couple of changes to comments in region.c (like turning
"RegionSubtract" back into "Subtract") that I'm not sure you intended.

By the way, Søren, I think an additional patch to use more of pixman
instead of duplicating it would be great, but I think Keith's taken
the right approach in preserving the existing implementation across
this refactoring.

Jamey


More information about the xorg-devel mailing list