[PATCH app-xkbcomp] config: add check for yacc to insure it is installed #27973

[Gaetan Nadon]

On Thu, 2010-06-03 at 08:47 +1000, Peter Hutterer wrote:

> On Wed, Jun 02, 2010 at 03:30:18PM -0400, Gaetan Nadon wrote:
> > Unlike other macros AC_PROG_YACC sets the YACC variable to "yacc"
> > as a last resort, even if no programs have been found. Improve error
> > checking by issuing an error message if yacc is not found. The module
> > cannot be build anyway.
> > 
> > Reported-by: Peter Hutterer <peter.hutterer at who-t.net>
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  configure.ac |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 4c86fcd..315910d 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -35,6 +35,8 @@ AM_CONFIG_HEADER(config.h)
> >  
> >  AC_PROG_CC
> >  AC_PROG_YACC
> > +AC_PATH_PROG([YACC_INST], $YACC)
> > +test -z $YACC_INST && AC_MSG_ERROR([yacc not found - unable to compile xkbparse.y])
> 
> should $YACC_INST be in quotes?
> 

It should, all the other ones are. 

I add the 4 other modules using AC_PROG_YACC on my TODO.


> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> >  AC_PROG_INSTALL
> 
> Cheers,
>   Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100602/775aaa11/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100602/775aaa11/attachment.pgp>