<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Thu, 2010-06-03 at 08:47 +1000, Peter Hutterer wrote: <BLOCKQUOTE TYPE=CITE> <PRE> On Wed, Jun 02, 2010 at 03:30:18PM -0400, Gaetan Nadon wrote: > Unlike other macros AC_PROG_YACC sets the YACC variable to "yacc" > as a last resort, even if no programs have been found. Improve error > checking by issuing an error message if yacc is not found. The module > cannot be build anyway. > > Reported-by: Peter Hutterer <<A HREF="mailto:peter.hutterer@who-t.net">peter.hutterer@who-t.net</A>> > Signed-off-by: Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>> > --- > configure.ac | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 4c86fcd..315910d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -35,6 +35,8 @@ AM_CONFIG_HEADER(config.h) > > AC_PROG_CC > AC_PROG_YACC > +AC_PATH_PROG([YACC_INST], $YACC) > +test -z $YACC_INST && AC_MSG_ERROR([yacc not found - unable to compile xkbparse.y]) should $YACC_INST be in quotes? </PRE> </BLOCKQUOTE> It should, all the other ones are. <BR> <BR> I add the 4 other modules using AC_PROG_YACC on my TODO.<BR> <BR> <BLOCKQUOTE TYPE=CITE> <PRE> Reviewed-by: Peter Hutterer <<A HREF="mailto:peter.hutterer@who-t.net">peter.hutterer@who-t.net</A>> > AC_PROG_INSTALL Cheers, Peter </PRE> </BLOCKQUOTE> </BODY> </HTML>