[PATCH app-xkbcomp] config: add check for yacc to insure it is installed #27973

Peter Hutterer peter.hutterer at who-t.net
Wed Jun 2 15:47:44 PDT 2010


On Wed, Jun 02, 2010 at 03:30:18PM -0400, Gaetan Nadon wrote:
> Unlike other macros AC_PROG_YACC sets the YACC variable to "yacc"
> as a last resort, even if no programs have been found. Improve error
> checking by issuing an error message if yacc is not found. The module
> cannot be build anyway.
> 
> Reported-by: Peter Hutterer <peter.hutterer at who-t.net>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4c86fcd..315910d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -35,6 +35,8 @@ AM_CONFIG_HEADER(config.h)
>  
>  AC_PROG_CC
>  AC_PROG_YACC
> +AC_PATH_PROG([YACC_INST], $YACC)
> +test -z $YACC_INST && AC_MSG_ERROR([yacc not found - unable to compile xkbparse.y])

should $YACC_INST be in quotes?

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

>  AC_PROG_INSTALL

Cheers,
  Peter


More information about the xorg-devel mailing list