Typo in recent xf86-video-ati commit (ATOM: Upstream parser updates)
Alex Deucher
alexdeucher at gmail.com
Wed Jan 20 06:20:14 PST 2010
2010/1/20 Oldřich Jedlička <oldium.pro at seznam.cz>:
> Hi Alex,
>
> I've just found that there are new commits in xf86-video-ati and one is
> suspicious to me - ATOM: Upstream parser updates. It contains lines:
>
> pParserTempData->DestData32=GetDestination[pParserTempData->ParametersType.Destination](pParserTempData);
> pParserTempData->SourceData32=GetParametersDirect(pParserTempData);
> - pParserTempData->Index=GetParametersDirect(pParserTempData);
> + pParserTempData->Index=GetSource[pParserTempData->ParametersType.Source](pParserTempData);
>
> Shouldn't the Index change go to SourceData32? It uses the same
> pattern as DestData32?
No, the code is correct as is. The mask op takes two sources: an AND
mask and an OR mask. The AND mask is always inline, while the OR mask
is now a full param.
Alex
More information about the xorg-devel
mailing list