Typo in recent xf86-video-ati commit (ATOM: Upstream parser updates)

[Oldřich Jedlička]

Hi Alex,

On Wednesday 20 of January 2010 at 15:20:14, Alex Deucher wrote:
> 2010/1/20 Oldřich Jedlička <oldium.pro at seznam.cz>:
> > Hi Alex,
> > 
> > I've just found that there are new commits in xf86-video-ati and one is
> > suspicious to me - ATOM: Upstream parser updates. It contains lines:
> > 
> >    
> > pParserTempData->DestData32=GetDestination[pParserTempData->ParametersTy
> > pe.Destination](pParserTempData);
> > pParserTempData->SourceData32=GetParametersDirect(pParserTempData); -  
> >  pParserTempData->Index=GetParametersDirect(pParserTempData); +  
> >  pParserTempData->Index=GetSource[pParserTempData->ParametersType.Source
> > ](pParserTempData);
> > 
> > Shouldn't the Index change go to SourceData32? It uses the same
> > pattern as DestData32?
> 
> No, the code is correct as is.  The mask op takes two sources: an AND
> mask and an OR mask.  The AND mask is always inline, while the OR mask
> is now a full param.

Thanks for clarification.

Oldřich.

> Alex
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel