Typo in recent xf86-video-ati commit (ATOM: Upstream parser updates)

Oldřich Jedlička oldium.pro at seznam.cz
Tue Jan 19 23:09:31 PST 2010


Hi Alex,

I've just found that there are new commits in xf86-video-ati and one is
suspicious to me - ATOM: Upstream parser updates. It contains lines:

     pParserTempData->DestData32=GetDestination[pParserTempData->ParametersType.Destination](pParserTempData);
     pParserTempData->SourceData32=GetParametersDirect(pParserTempData);
-    pParserTempData->Index=GetParametersDirect(pParserTempData);
+    pParserTempData->Index=GetSource[pParserTempData->ParametersType.Source](pParserTempData);

Shouldn't the Index change go to SourceData32? It uses the same
pattern as DestData32?

Cheers,
Oldřich.


More information about the xorg-devel mailing list