[PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle
ville.syrjala at nokia.com
Mon Dec 20 10:03:25 PST 2010
On Mon, Dec 20, 2010 at 01:04:07PM -0500, ext Adam Jackson wrote:
> On Mon, 2010-12-20 at 18:05 +0200, ville.syrjala at nokia.com wrote:
> > From: Ville Syrjälä <ville.syrjala at nokia.com>
> > Eliminate the internal MapWindow+UnmapWindow cycle around window
> > redirection changes. Instead do the work in a single pass by marking
> > the afected windows and calling ValidateTree and HandleExposures
> > directly. This gets rid of unnecessary expose events, and invalid
> > ClipNotify calls during rediredction changes. Now ClipNotify will only
> > get called with the final clip values, and expose events are only sent
> > to areas that actually got exposed.
> This can't be right, I don't think. You've eliminated the Map/Unmap
> cycle - entirely laudable, thank you for taking it on - but in doing so
> you're not replacing it with a call path that ever hits ->RealizeWindow,
> so the backing pixmaps aren't ever going to be created.
> Am I missing something?
More information about the xorg-devel