[PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle

Adam Jackson ajax at nwnk.net
Mon Dec 20 10:12:52 PST 2010


On Mon, 2010-12-20 at 20:03 +0200, Ville Syrjälä wrote:
> On Mon, Dec 20, 2010 at 01:04:07PM -0500, ext Adam Jackson wrote:
> > This can't be right, I don't think.  You've eliminated the Map/Unmap
> > cycle - entirely laudable, thank you for taking it on - but in doing so
> > you're not replacing it with a call path that ever hits ->RealizeWindow,
> > so the backing pixmaps aren't ever going to be created.
> > 
> > Am I missing something?
> 
> compCheckRedirect()

Indeed!  Right, I'm convinced.  This looks much nicer than what we had
before.  For the series:

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101220/fbb2c267/attachment.pgp>


More information about the xorg-devel mailing list