[PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle

Adam Jackson ajax at nwnk.net
Mon Dec 20 10:04:07 PST 2010

On Mon, 2010-12-20 at 18:05 +0200, ville.syrjala at nokia.com wrote:
> From: Ville Syrjälä <ville.syrjala at nokia.com>
> Eliminate the internal MapWindow+UnmapWindow cycle around window
> redirection changes. Instead do the work in a single pass by marking
> the afected windows and calling ValidateTree and HandleExposures
> directly. This gets rid of unnecessary expose events, and invalid
> ClipNotify calls during rediredction changes. Now ClipNotify will only
> get called with the final clip values, and expose events are only sent
> to areas that actually got exposed.

This can't be right, I don't think.  You've eliminated the Map/Unmap
cycle - entirely laudable, thank you for taking it on - but in doing so
you're not replacing it with a call path that ever hits ->RealizeWindow,
so the backing pixmaps aren't ever going to be created.

Am I missing something?

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101220/d19ad9f1/attachment.pgp>

More information about the xorg-devel mailing list