Input shaping

Kevin E Martin kem at freedesktop.org
Mon Mar 28 11:56:03 PST 2005


On Thu, Mar 24, 2005 at 09:30:31PM +0100, Roland Mainz wrote:
> Soeren Sandmann wrote:
> > 
> > In this thread:
> > 
> >       http://lists.freedesktop.org/pipermail/xorg/2005-January/005962.html
> > 
> > Keith describes and extension to the Shape extension allowing windows
> > to have an "input shape" in addition to the exisiting clip and
> > bounding shapes.
> > 
> > The patch attached to that message was committed to Keith's xserver
> > tree, but not
> > to the xorg tree. At
> > 
> >    http://www.daimi.au.dk/~sandmann/input-shape.patch
> > 
> > there is a port of his patch to the xorg tree. The patch is also
> > attached to this message.
> > 
> > If this is considered a good idea, I will update the protocol and
> > library documentation
> > for the shape protocol.
> > 
> > I originally posted about this to the xorg list, and Roland pointed out
> > that xorg-arch
> > is really the right list to discuss this since it is an API extension.
> > He also pointed out that
> > the Xnest and Xdmx may need to be updated to be in sync with this change.
> 
> I consider the idea a good one, however I'd like to see some things
> which should be adjusted/added to the patch and commited in one step
> with it:
> 1. I'd like to see some comments from Paul Anderson/HP and Sun
> (Stuart/Alan etc.) whether they like the patch
> 2. with the protocol extension a client-side demo should be implemented
> (for example via using a "empty" input shape for the Xaw tooltips (e.g.
> all clicks are passed throught))
> 3. Xnest needs to be updated
> 4. Xdmx needs to be updated
> 5. the patch is little bit underdocumented - I'd like to see both
> comments in the header files that this was added later and how a
> cliet-side can detect this
> 6. the manual pages needs to be updated
> 
> Please attach the current patch to a bugzilla bug and I can try working
> on [2], [3] and [5] this weekend... [6] requires someone who still knows
> about the old troff man page format (alanc ?),  [4] should be done by
> Kevin...

Unless I'm missing something, this looks to be rather trivial to add for
DMX, but I've only glanced through the patch.  It looks like I would
just need to add support for pushing pWin->optional->inputShape to the
back-end servers if wInputShape(pWin) is !NULL.

Kevin


More information about the xorg-arch mailing list