[PATCH 1/5] build: use AC_CONFIG_MACRO_DIR as per libtoolize warning

Gaetan Nadon memsize at videotron.ca
Sun Nov 28 13:39:18 PST 2010

On Sun, 2010-11-28 at 21:26 +0100, Jan Engelhardt wrote:

> On Sunday 2010-11-28 19:45, Gaetan Nadon wrote:
> >On Sun, 2010-11-28 at 15:46 +0100, Jan Engelhardt wrote:
> >      +ACLOCAL_AMFLAGS = -I m4
> >
> >This will fail if m4 does not exist at clone time.
> >It won't because there is a .gotognore file in there.
> >However, it will be suggested later to use the same
> >toplevel .gitignore file that is used in all other 240 xorg modules.
> Then perhaps you need to update the master xorg .gitignore, because the 
> suggestion to use ACLOACL_AMFLAGS will appear on any project with a 
> libtool library.

The suggestion to use ACLOCAL_AMFLAGS come from the Autoconf tools.
I looked at the warnings and the output of autoupdate and autoscan and
are plenty of warnings that do not apply.

If you are using 2.65 (or even 2.68), it will give you warnings that are
not applicable
to 2.60. The docs don't tell you (or rarely) which features belong to
which release.

The .gitignore file is not related to Autotools, just git. If you end up
with an empty m4
directory, and you have -I m4, aclocal will fail. In fact you should not
have -I m4
anyway because you have no macros in there.

If you install the toplevel .gitignore as I suggested, you can
remove .gitignore from m4.
Then you need to remove -I m4 or it will fail during a clone. That's the
chain of events
I was warning about.

If you grep for -I m4 in other xorg modules, you'll the pattern.

I thought I'd share stuff I learned the hard way!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg/attachments/20101128/44c9bd83/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20101128/44c9bd83/attachment.pgp>

More information about the xorg mailing list