[PATCH] mi: Hush extension initialization (#75870)

[Kristian Høgsberg]

On Thu, Mar 27, 2014 at 8:48 AM, Adam Jackson <ajax at redhat.com> wrote:
> Printing these as ErrorF is fairly obnoxious, since it means the
> non-hardware servers now spew stuff to the console for entirely routine
> events.  And actually, printing these at all is fairly obnoxious, since
> a) we're printing a line for every extension, whether it's enabled or
> not, and b) we're not actually initializing the extension at this point.

I can get behind that.

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  mi/miinitext.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/mi/miinitext.c b/mi/miinitext.c
> index 5b45ab4..1d90516 100644
> --- a/mi/miinitext.c
> +++ b/mi/miinitext.c
> @@ -365,7 +365,6 @@ void
>  LoadExtensionList(const ExtensionModule ext[], int size, Bool builtin)
>  {
>      ExtensionModule *newext;
> -    const char *msg;
>      int i;
>
>      /* Make sure built-in extensions get added to the list before those
> @@ -375,14 +374,7 @@ LoadExtensionList(const ExtensionModule ext[], int size, Bool builtin)
>      if (!(newext = NewExtensionModuleList(size)))
>          return;
>
> -    if (builtin)
> -        msg = "Initializing built-in";
> -    else
> -        msg = "Loading";
> -
>      for (i = 0; i < size; i++, newext++) {
> -        ErrorF("%s extension %s\n", msg, ext[i].name);
> -
>          newext->name = ext[i].name;
>          newext->initFunc = ext[i].initFunc;
>          newext->disablePtr = ext[i].disablePtr;
> --
> 1.8.5.3
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel