xditview '.' hangs: Errata to my previous mail :(

[Krzysztof Żelechowski]

Dnia środa, 8 grudnia 2010 o 18:10:40 Pat Kane napisał(a):
>  > Examine the value returned by read() instead of doing either.
> 
> The "read()" is down in libc.so which is done by "getc()".
> So there may be a bug in libc, but I don't have time
> right now to look at it.

getc is OK to call read, that is what it normally does in the GNU C Library.   

Bad code:

c = getc (...); process (c);

Good code:

if ((c = getc (...)) == EOF) { perror ("read"); ...; } else process (c);


> 
> I submitted a new version of the patch to xorg-devel:
>     http://lists.x.org/archives/xorg-devel/2010-December/016861.html
> please take a look and give it a "Reviewed-by" and or "Tested-by"
> line if you can .
> 
> Pat
> ---
>