Asking for review of patch for bug #19337

Frank de Lange freedesktop-f at unternet.org
Mon Jan 19 15:48:03 PST 2009


Alex Villací­s Lasso wrote:
> A few days ago, I posted a patch for bug #19337, which affects the 
> savage driver with current xserver git, and possibly many other 
> non-xrandr 1.2 enabled drivers. I think this patch needs to be reviewed 
> and possibly merged, because it fixes an annoying crashing regression 
> with users not fortunate enough to have an ATI/Intel/NVidia video 
> chipset as their primary display. Apparently the bug reporter does find 
> that his bug was fixed with this. What do you think?
> 

I am the bug reporter, and also the author of the first patch (which I
included with the bug report). I have been running with the patched
driver ever since I posted that patch. I have not tried your patch yet
but I do notice that someone else (not the original bug reporter which
was me...) has reported that your patch also fixes the crash. As your
patch fixes the problem at the source (the X server) while mine only
fixes the symptom (crashing driver) I'll give it a try and report back...

Cheers//Frank



More information about the xorg mailing list