[PATCH] egl: Use -dlopen rather than -dl which is non portable
brianp at vmware.com
Wed Feb 25 07:24:59 PST 2009
Dan Nicholson wrote:
> On Tue, Feb 24, 2009 at 8:51 PM, Benjamin Close
> <Benjamin.Close at clearchain.com> wrote:
>> Signed-off-by: Benjamin Close <Benjamin.Close at clearchain.com>
>> src/egl/main/Makefile | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> diff --git a/src/egl/main/Makefile b/src/egl/main/Makefile
>> index 89b4a20..a543f67 100644
>> --- a/src/egl/main/Makefile
>> +++ b/src/egl/main/Makefile
>> @@ -63,7 +63,7 @@ library: $(TOP)/$(LIB_DIR)/libEGL.so
>> $(TOP)/$(LIB_DIR)/libEGL.so: $(OBJECTS)
>> $(MKLIB) -o EGL -linker '$(CC)' -ldflags '$(LDFLAGS)' \
>> -major 1 -minor 0 \
>> - -install $(TOP)/$(LIB_DIR) -ldl $(OBJECTS) $(LIBS)
>> + -install $(TOP)/$(LIB_DIR) -dlopen $(OBJECTS) $(LIBS)
> Does this actually work? The -dlopen option is being passed to mklib,
> which doesn't seem to do anything useful with it. I suspect this has
> broken the build on linux.
I did a quick build test (on Linux) and it worked.
-dlopen is a valid mklib option but a no-op for most platforms. Its
meaning is different than -ldl though.
> We already handle dlopen in libc on BSD in configure by setting
> DLOPEN_LIBS and adding them to GL_LIB_DEPS and DRI_LIB_DEPS. We should
> probably just do the same for egl.
That sounds right. I'll look at that.
More information about the xorg