[PATCH] egl: Use -dlopen rather than -dl which is non portable

Dan Nicholson dbn.lists at gmail.com
Wed Feb 25 07:10:20 PST 2009


On Tue, Feb 24, 2009 at 8:51 PM, Benjamin Close
<Benjamin.Close at clearchain.com> wrote:
> Signed-off-by: Benjamin Close <Benjamin.Close at clearchain.com>
> ---
>  src/egl/main/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/egl/main/Makefile b/src/egl/main/Makefile
> index 89b4a20..a543f67 100644
> --- a/src/egl/main/Makefile
> +++ b/src/egl/main/Makefile
> @@ -63,7 +63,7 @@ library: $(TOP)/$(LIB_DIR)/libEGL.so
>  $(TOP)/$(LIB_DIR)/libEGL.so: $(OBJECTS)
>        $(MKLIB) -o EGL -linker '$(CC)' -ldflags '$(LDFLAGS)' \
>                -major 1 -minor 0 \
> -               -install $(TOP)/$(LIB_DIR) -ldl $(OBJECTS) $(LIBS)
> +               -install $(TOP)/$(LIB_DIR) -dlopen $(OBJECTS) $(LIBS)

Does this actually work? The -dlopen option is being passed to mklib,
which doesn't seem to do anything useful with it. I suspect this has
broken the build on linux.

We already handle dlopen in libc on BSD in configure by setting
DLOPEN_LIBS and adding them to GL_LIB_DEPS and DRI_LIB_DEPS. We should
probably just do the same for egl.

--
Dan



More information about the xorg mailing list