[Linux-gfx] Re: [PATCH 3/5] handle extenion for detail timing block

[Ma, Ling]

hi ajax
I have appended quirk function in handle_detailed_fn before we really use detail timing.
It is not useful to us any longer, so I remove it.

Thanks
Ma Ling

>-----Original Message-----
>From: linux-gfx-bounces at linux.intel.com 
>[mailto:linux-gfx-bounces at linux.intel.com] On Behalf Of Adam Jackson
>Sent: 2008年11月19日 4:56
>To: Ma, Ling
>Cc: linux-gfx at linux.intel.com; xorg at lists.freedesktop.org
>Subject: [Linux-gfx] Re: [PATCH 3/5] handle extenion for 
>detail timing block
>
>On Mon, 2008-11-17 at 16:46 +0800, ling.ma at intel.com wrote:
>
>> @@ -2687,14 +2725,9 @@ xf86OutputGetEDIDModes (xf86OutputPtr output)
>>  _X_EXPORT xf86MonPtr
>>  xf86OutputGetEDID (xf86OutputPtr output, I2CBusPtr pDDCBus)
>>  {
>> -    ScrnInfoPtr	scrn = output->scrn;
>> -    xf86MonPtr mon;
>>  
>> -    mon = xf86DoEEDID(scrn->scrnIndex, pDDCBus, TRUE);
>> -    if (mon)
>> -        xf86DDCApplyQuirks(scrn->scrnIndex, mon);
>> +    return  xf86DoEEDID(output->scrn->scrnIndex, pDDCBus, TRUE);
>>  
>> -    return mon;
>>  }
>>  
>>  static char *_xf86ConnectorNames[] = {
>
>I'm really not sure why you've moved quirk application from 
>something we
>do once when we get the EDID block, to something we do every time we
>walk the detailed descriptors.  What's the motivation for that?
>
>- ajax
>