[PATCH 3/5] handle extenion for detail timing block

[Adam Jackson]

On Mon, 2008-11-17 at 16:46 +0800, ling.ma at intel.com wrote:

> @@ -2687,14 +2725,9 @@ xf86OutputGetEDIDModes (xf86OutputPtr output)
>  _X_EXPORT xf86MonPtr
>  xf86OutputGetEDID (xf86OutputPtr output, I2CBusPtr pDDCBus)
>  {
> -    ScrnInfoPtr	scrn = output->scrn;
> -    xf86MonPtr mon;
>  
> -    mon = xf86DoEEDID(scrn->scrnIndex, pDDCBus, TRUE);
> -    if (mon)
> -        xf86DDCApplyQuirks(scrn->scrnIndex, mon);
> +    return  xf86DoEEDID(output->scrn->scrnIndex, pDDCBus, TRUE);
>  
> -    return mon;
>  }
>  
>  static char *_xf86ConnectorNames[] = {

I'm really not sure why you've moved quirk application from something we
do once when we get the EDID block, to something we do every time we
walk the detailed descriptors.  What's the motivation for that?

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20081118/2f067086/attachment.pgp>