[patch] Re: HAL and hotplugging

[Sascha Hlusiak]

Am Samstag 15 März 2008 22:36:47 schrieb Dustin Spicuzza:
> -    for (i = 0; props[i]; i++) {
> +    for (i = 0; capabilities[i]; i++) {
>          /* input.keys is the new, of which input.keyboard is a subset, but
>           * input.keyboard is the old 'we have keys', so we have to keep it
>           * around. */
> -        if (strcmp(props[i], "input.keys") == 0 ||
> -            strcmp(props[i], "input.keyboard") == 0)
> +        if (strcmp(capabilities[i], "input.keys") == 0 ||
> +            strcmp(capabilities[i], "input.keyboard") == 0)
>              type |= TYPE_KEYS;
> -        if (strcmp(props[i], "input.mouse") == 0 ||
> -            strcmp(props[i], "input.touchpad") == 0)
> +        if (strcmp(capabilities[i], "input.mouse") == 0 ||
> +            strcmp(capabilities[i], "input.touchpad") == 0)
>              type |= TYPE_POINTER;
>      }

Can we get rid of that whole block, please? Why check for certain input.* 
capabilities when input.x11_driver should be totally enough for deciding if 
we can hotplug this or not (just exit and don't print an error when 
input.x11_driver is not set). That way we can hotplug devices that are not 
input.keys or input.mouse or input.touchpad, like a joystick with the 
joystick driver. 

- Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.x.org/archives/xorg/attachments/20080316/55fe4dba/attachment.pgp>