pciaccess conversion the revenge..

[Paulo Cesar Pereira de Andrade]

Daniel Stone wrote:
> On Tue, Mar 11, 2008 at 04:24:13PM -0300, Paulo Cesar Pereira de Andrade wrote:
>> Daniel Stone wrote:
>>> Rush isn't used anywhere at all.
>>  So the proper fix would be something like (pseudo patch):
>> +#if XF86RUSH
>>     if (ApmGeneration != serverGeneration) {
>>         if ((ApmPixmapIndex = AllocatePixmapPrivateIndex()) < 0)
>>             return FALSE;
>>         ApmGeneration = serverGeneration;
>>     }
>>     if (!AllocatePixmapPrivate(pScreen, ApmPixmapIndex,  
>> sizeof(ApmPixmapRec)))
>>         return FALSE;
>> +#endif
>
> Just delete it.
>
>>> It's so, so much easier to just fix up all the old drivers.
>>  Not really, if the developer cannot test the changes.
>
> If you can't test the changes, then you can't test the changes, full
> stop: no matter whether you're changing the driver or the server.

  Actually, writing a (temporary) compatibility module would fix
problems without need of testing, or recompile, assuming it would
export the same abi and functionality, and enough tests are done
in the "available" hardware.

  Anyway, if the X Server and modules keep changing api/abi, some
method, tinderbox or whatever must be enforced. So that developers
will at least know things are broken, and don't "carry" either
unbuildable or "plain broken" system for so long.

> Cheers,
> Daniel

Paulo