pciaccess conversion the revenge..

[Daniel Stone]

On Tue, Mar 11, 2008 at 04:24:13PM -0300, Paulo Cesar Pereira de Andrade wrote:
> Daniel Stone wrote:
>> Rush isn't used anywhere at all.
>
>  So the proper fix would be something like (pseudo patch):
> +#if XF86RUSH
>     if (ApmGeneration != serverGeneration) {
>         if ((ApmPixmapIndex = AllocatePixmapPrivateIndex()) < 0)
>             return FALSE;
>         ApmGeneration = serverGeneration;
>     }
>     if (!AllocatePixmapPrivate(pScreen, ApmPixmapIndex,  
> sizeof(ApmPixmapRec)))
>         return FALSE;
> +#endif

Just delete it.

>> It's so, so much easier to just fix up all the old drivers.
>  Not really, if the developer cannot test the changes.

If you can't test the changes, then you can't test the changes, full
stop: no matter whether you're changing the driver or the server.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20080311/3a954f0c/attachment.pgp>