[PATCH] Require bash shell for symlink-mesa.sh

[Matthieu Herrb]

Dan Nicholson wrote:
> On Fri, Mar 7, 2008 at 5:27 PM, Joerg Sonnenberger
> <joerg at britannica.bec.de> wrote:
>> On Fri, Mar 07, 2008 at 04:38:01PM -0800, Dan Nicholson wrote:
>>  > The symlink-mesa.sh script has a few bashisms, but is currently invoked
>>  > through /bin/sh. This is a problem if /bin/sh isn't bash. Instead,
>>  > require bash and use it to process symlink-mesa.sh.
>>
>>  What about fixing it to work with sh instead? This is unacceptable for
>>  the BSDs...

Seconded.
> 
> That'd be the nice thing to do, yes, but a little more work. How do
> the BSDs deal with this now? 

Afaict, I've not run into problems with OpenBSD's /bin/sh which is based
on pdksh.


> Is there another shell this works with? I
> could easily change the check to something like:
> 

I think using /bin/ksh would be ok for most systems. But I may need to
recheck my build logs for un-noticed errors though.

> AC_PATH_PROG(MESA_SHELL, bash zsh othermagicshell, ...
> 
> --
> Dan
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg


-- 
Matthieu Herrb