[PATCH] make xf86SetDesiredModes a bit more driver friendly

Jesse Barnes jbarnes at virtuousgeek.org
Fri Mar 7 14:07:26 PST 2008

On Thursday, March 06, 2008 5:18 pm Jesse Barnes wrote:
> This is the better tested version of the DPMS off patch, and includes
> aaronp's suggestion of removing the "xf86DisableUnusedFunctions" calls from
> xf86SetDesiredModes and xf86RandR12CrtcSet (the single mode function still
> uses it, but I think that's not used?).
> I tested with the attached patch for Intel.  It's important to only set the
> output->crtc field if a given output is on at startup time or the core code
> will remove all your modes.
> Look ok?  I would be good if some other driver people looked at it as
> well...

Ok, here's an updated set including Eric's feedback.  He also made me think a 
little more about the xf86DisableUnusedFunctions change.  I think removing it 
from the core would mean more driver changes than I'd like, so I'll leave it 
up to Aaron to change the way that's done.  We could have a global flag in 
the xf86_config structure to control whether it's called, or maybe change it 
into an xf86_config function pointer like ->resize...

Anyway, this patchset seems to work ok for me.  Any more comments?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: i830-initial-config-3.patch
Type: text/x-diff
Size: 7493 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080307/93876c4a/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xserver-randr-13-set-desired-mode-fixes-2.patch
Type: text/x-diff
Size: 860 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080307/93876c4a/attachment-0001.patch>

More information about the xorg mailing list